Expose user agent and pass header through in requests #32
Conversation
|
|
||
| @Test | ||
| public void testDefaultUserAgent() throws Exception { | ||
| RestClient restClient = RestClient.builder(new HttpHost("localhost", 9200)).build(); |
There was a problem hiding this comment.
Drive by nit (hi 👋): IIRC the rest client starts a threadpool with every invocation and is Closeable. Maybe start the client only once for the whole test and make sure it is closed after?
There was a problem hiding this comment.
Hi back :)
Yes, that seems like good advice. Given this is my first foray into this code base, I was just about to ping @swallez for his thoughts; I'll add this to the list for discussion.
There was a problem hiding this comment.
@spinscale WDYT of the latest commit?
There was a problem hiding this comment.
👍 (as long as we don't have mockito as a dependency ;-) - I also opened #33 as a discussion to prevent such issues in the future, but that depends if we want to use junit jupiter in the future I guess
|
Closing PR and reopening as #35 for all telemetry changes. |
No description provided.